fix(editor): convert tables without <th> cells during rich paste#1286
Merged
Conversation
turndown-plugin-gfm only recognizes a table's header row when its cells are literal <th> elements, and otherwise keeps the whole table as raw, unconverted HTML. Many real paste sources (Google Sheets, plain web tables, Excel-to-HTML) render every cell as <td>, so their tables were silently dropped as raw HTML instead of becoming markdown. Also wires rich paste behind Ctrl/Cmd+Shift+V instead of plain paste while it's being tested, and moves pasteRich/pastePlain out of the imperative handle into MarkdownEditor callbacks passed down to the CodeMirror keymap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
turndown-plugin-gfm only recognizes a table's header row when its cells are literal elements, and otherwise keeps the whole table as raw, unconverted HTML. Many real paste sources (Google Sheets, plain web tables, Excel-to-HTML) render every cell as , so their tables were silently dropped as raw HTML instead of becoming markdown.
Also wires rich paste behind Ctrl/Cmd+Shift+V instead of plain paste while it's being tested, and moves pasteRich/pastePlain out of the imperative handle into MarkdownEditor callbacks passed down to the CodeMirror keymap.