fix(ui): eliminate double-blink when closing add-page dialog#1224
Merged
Conversation
resetForm() was called inside handleCreate before returning true, causing the form reset and closeDialog() to land in the same React render — the user briefly saw empty fields before the close animation. Remove the explicit resetForm(); state resets naturally on unmount. Also remove renderType from the DialogManager useEffect dependency array — it is only ever set by the effect, never read, causing an unnecessary second effect pass on every dialog open/close.
Remove the unused resetForm dependency from AddPageDialog handleCreate. This clears the React hooks lint warning without changing dialog behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resetForm() was called inside handleCreate before returning true, causing the form reset and closeDialog() to land in the same React render — the user briefly saw empty fields before the close animation. Remove the explicit resetForm(); state resets naturally on unmount.
Also remove renderType from the DialogManager useEffect dependency array — it is only ever set by the effect, never read, causing an unnecessary second effect pass on every dialog open/close.