Skip to content

fix(editor): preserve custom title property through UI edit cycle#1189

Merged
perber merged 3 commits into
mainfrom
fix/title-property-preserved-on-edit
Jun 26, 2026
Merged

fix(editor): preserve custom title property through UI edit cycle#1189
perber merged 3 commits into
mainfrom
fix/title-property-preserved-on-edit

Conversation

@perber

@perber perber commented Jun 21, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings June 21, 2026 09:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@perber perber linked an issue Jun 22, 2026 that may be closed by this pull request
4 tasks
perber added 3 commits June 23, 2026 17:25
Pages with `title` + `leafwiki_title` in frontmatter lost the `title`
value on every UI save because it was treated as a reserved key.

- `HasLeafWikiTitle` flag distinguishes explicit `leafwiki_title` from the alias case
- `IsSystemKey()` replaces three diverging local reserved-key maps
- `UpsertContentAndMetadata`: new UI-edit path taking structured body/tags/props
- `title` removed from frontend property key validation
…operty

Removes the HasLeafWikiTitle sentinel flag from Frontmatter and the
associated conditional filtering in extractPageMetadata,
ExtractPropertiesFromContent, and validatePageMetadataInput. A 'title'
key in ExtraFields is now unconditionally a user-defined custom property
that round-trips through the editor unchanged.
Clearer name — the flag means "treat content as raw markdown with
embedded frontmatter", which applies to both imports and revision restores.
@perber
perber force-pushed the fix/title-property-preserved-on-edit branch from 1e27a49 to de57545 Compare June 25, 2026 13:00
@perber
perber merged commit 163d2d0 into main Jun 26, 2026
9 checks passed
@perber
perber deleted the fix/title-property-preserved-on-edit branch June 26, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom frontmatter property "title" is removed when editing through LeafWiki UI

2 participants