fix(editor): prevent Page404 flash when navigating to edit mode#1181
Merged
Conversation
setLoading(true) was called after resetting initialPage to null, leaving a window where !initialPage && !loading was true on the first render — briefly showing the 404 page before the load even started. Moving setLoading(true) before the store reset ensures React 18 auto-batching renders both updates together, so the 404 condition is never met.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a UI flash in the editor route where <Page404 /> could briefly render during navigation into edit mode. It does this by ensuring the global progress/loading state is set to true before the editor store is reset, so the !initialPage && !loading render condition in PageEditor.tsx is never transiently satisfied during a load.
Changes:
- Reorders
useProgressbarStore.setLoading(true)to run before resettinginitialPagetonullinloadPageData. - Eliminates the brief “404” render window during page-load transitions into edit mode.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setLoading(true) was called after resetting initialPage to null, leaving a window where !initialPage && !loading was true on the first render — briefly showing the 404 page before the load even started. Moving setLoading(true) before the store reset ensures React 18 auto-batching renders both updates together, so the 404 condition is never met.