perf(ui): load PageViewer and MarkdownPreview eagerly to eliminate render waterfall#1180
Merged
Conversation
…nder waterfall Every page view requires both PageViewer and MarkdownPreview. Lazy loading them caused a 3-step sequential fetch (index → PageViewer → MarkdownPreview) on every page load. Making PageViewer eager pulls MarkdownPreview into the main bundle, eliminating the waterfall at the cost of a larger initial chunk (446 kB → 1261 kB unminified; 141 kB → 389 kB gzip). Total bytes transferred remain nearly identical.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the UI’s initial page render by removing a sequential lazy-load chain for the page view route. Since every page view always needs PageViewer (and it in turn needs MarkdownPreview), the change makes PageViewer an eager import so it lands in the main bundle and avoids a render-time waterfall.
Changes:
- Stop lazily importing
PageViewerand instead export it eagerly from the routes module. - Keep other route components lazily loaded while ensuring the common page-view path no longer incurs extra sequential chunk fetches.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every page view requires both PageViewer and MarkdownPreview. Lazy loading them caused a 3-step sequential fetch (index → PageViewer → MarkdownPreview) on every page load. Making PageViewer eager pulls MarkdownPreview into the main bundle, eliminating the waterfall at the cost of a larger initial chunk (446 kB → 1261 kB unminified; 141 kB → 389 kB gzip). Total bytes transferred remain nearly identical.