feat(i18n): localize BrandingSettings page#1176
Merged
Merged
Conversation
Add branding namespace with all strings for site name, logo, favicon
sections including labels, descriptions, placeholders, hints, and
toast messages. Wire up useTranslation('branding') in BrandingSettings.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR localizes the BrandingSettings page by introducing a dedicated branding i18n namespace and wiring the page UI strings (section titles, descriptions, hints, and toast messages) through react-i18next.
Changes:
- Added a new English locale namespace file for branding-related strings (
branding.json). - Registered the new
brandingnamespace in the i18n resource initialization. - Updated
BrandingSettingsto useuseTranslation('branding')for all previously hardcoded UI text and toast messages.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ui/leafwiki-ui/src/locales/en/branding.json | Adds the new branding namespace strings for the Branding Settings page UI and toasts. |
| ui/leafwiki-ui/src/lib/i18n.ts | Registers branding in the i18next resources.en bundle. |
| ui/leafwiki-ui/src/features/branding/BrandingSettings.tsx | Replaces hardcoded strings with t(...) lookups for page title, labels, hints, and toast messages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add branding namespace with all strings for site name, logo, favicon sections including labels, descriptions, placeholders, hints, and toast messages. Wire up useTranslation('branding') in BrandingSettings.