fix(ui): constrain branding logo to fit within header on mobile#1175
Merged
Conversation
Logo image had h-16 (64px) but the header is only h-[55px] with p-4 padding, leaving only ~23px of inner space. On mobile this caused the banner to overflow and push other UI elements out of alignment. Fix: replace h-16 with h-auto max-h-9 (36px) so the image scales down to fit. Add overflow-hidden to the header as a safety net.
Contributor
There was a problem hiding this comment.
⚠️ Not ready to approve
The updated logo max-height (36px) is still larger than the header’s available inner height (~22–23px), so the logo may still overflow and be clipped rather than reliably scaling to fit.
Pull request overview
This PR adjusts the UI header branding so the site logo doesn’t overflow the fixed-height header on mobile, aiming to keep the header layout stable across screen sizes.
Changes:
- Adds
overflow-hiddento.app-layout__headerto prevent visual overflow from header contents. - Updates
.app-layout__logo-imagesizing from a fixed height (h-16) to a constrained, scalable height (h-autowith a max height).
File summaries
| File | Description |
|---|---|
| ui/leafwiki-ui/src/index.css | Constrains header/logo styling to prevent mobile header overflow. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logo image had h-16 (64px) but the header is only h-[55px] with p-4 padding, leaving only ~23px of inner space. On mobile this caused the banner to overflow and push other UI elements out of alignment.
Fix: replace h-16 with h-auto max-h-9 (36px) so the image scales down to fit. Add overflow-hidden to the header as a safety net.