fix(auth): use primary button + i18n for login form and toolbar#1172
Merged
Conversation
Replaces the custom brand-colored login button in UserToolbar with the standard Button component (primary variant), removes the redundant "Not logged in" label, and adds an auth i18n namespace covering all login-form and toolbar strings.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the unauthenticated login CTA in the UserToolbar by switching to the shared Button component and introduces an auth i18n namespace to localize login-related UI strings.
Changes:
- Added a new
authEnglish locale namespace and registered it with i18next. - Updated
LoginFormplaceholders and submit button text to usereact-i18next. - Updated
UserToolbarto use the sharedButton(small) for the login action, removed the custom login-button CSS, and localized unauthenticated/auth-disabled labels.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ui/leafwiki-ui/src/locales/en/auth.json | Adds new auth namespace strings for login-related UI. |
| ui/leafwiki-ui/src/lib/i18n.ts | Registers the auth namespace in i18next resources. |
| ui/leafwiki-ui/src/index.css | Removes styling for the now-deleted custom toolbar login button class. |
| ui/leafwiki-ui/src/features/auth/LoginForm.tsx | Replaces hardcoded login form strings with t(...) lookups. |
| ui/leafwiki-ui/src/components/UserToolbar.tsx | Uses shared Button for login CTA and localizes unauthenticated/auth-disabled labels. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the custom brand-colored login button in UserToolbar with the standard Button component (primary variant), removes the redundant "Not logged in" label, and adds an auth i18n namespace covering all login-form and toolbar strings.