feat(links): hide broken links section for read-only users and i18n b…#1140
Merged
Conversation
…acklink strings Broken link info is only actionable for editors; viewers see no benefit from it. Guard the section with useIsReadOnly() and move all hardcoded backlink strings into the viewer locale.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the UI link metadata pane to (1) hide the “Broken links” section for read-only users and (2) internationalize backlink-related UI strings by moving them into the viewer locale namespace.
Changes:
- Add
viewer.backlinks.*strings to the English viewer locale and wire them into the backlinks UI. - Guard the “Broken links” subsection behind
useIsReadOnly()so it only appears for users who can act on it.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ui/leafwiki-ui/src/locales/en/viewer.json | Adds markdownPreview and backlinks translation keys under the viewer namespace. |
| ui/leafwiki-ui/src/features/links/LinkInfo.tsx | Uses viewer i18n keys for backlink UI strings and hides the broken-links group for read-only users. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…p on error Moves the error message outside the read-only guard so read-only users see the error instead of a misleading empty backlinks state. Also hides the broken links group entirely when an error occurred.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…acklink strings
Broken link info is only actionable for editors; viewers see no benefit from it. Guard the section with useIsReadOnly() and move all hardcoded backlink strings into the viewer locale.