fix(ui): replace dialog slide animation with subtle fade/scale#1100
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the LeafWiki UI dialog and alert-dialog components to remove directional slide-in/slide-out transitions and rely on the existing fade/zoom utilities, yielding a centered, symmetric open/close animation.
Changes:
- Removed
slide-in-from-*andslide-out-to-*state-based utility classes from dialog content animations. - Kept the existing
animate-in/out,fade-in/out, andzoom-in/out-95utilities to provide a subtle fade/scale transition.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ui/leafwiki-ui/src/components/ui/dialog.tsx | Removes directional slide animation classes from DialogContent while retaining fade/zoom transitions. |
| ui/leafwiki-ui/src/components/ui/alert-dialog.tsx | Removes directional slide animation classes from AlertDialogContent while retaining fade/zoom transitions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Dialogs were flying in from the upper-left corner due to slide-in-from-left-1/2 and slide-in-from-top-[48%] classes, with no matching close animation. Removed all four directional slide classes from both dialog.tsx and alert-dialog.tsx; the remaining fade-in/out and zoom-in/out-95 utilities produce a centered, symmetric transition.
perber
force-pushed
the
worktree-fix+dialog-animation
branch
from
June 2, 2026 12:42
76290eb to
f9cd256
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dialogs were flying in from the upper-left corner due to slide-in-from-left-1/2 and slide-in-from-top-[48%] classes, with no matching close animation. Removed all four directional slide classes from both dialog.tsx and alert-dialog.tsx; the remaining fade-in/out and zoom-in/out-95 utilities produce a centered, symmetric transition.