fix(branding): validate file paths before deletion to prevent path traversal#1090
Merged
Conversation
…aversal Add containsPathTraversal check in DeleteLogo and DeleteFavicon, mirroring the same guard already present in resolveBrandingAssetPath for asset serving. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens branding asset deletion by adding a path-traversal guard before removing logo and favicon files, aligning deletion behavior with existing asset-serving protections.
Changes:
- Adds a
containsPathTraversalhelper for validating stored branding filenames. - Applies the guard in
DeleteLogoandDeleteFaviconto prevent deleting paths outside the branding assets directory.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Block absolute and volume-based asset paths during logo and favicon deletion. Add tests to verify invalid stored paths fail without deleting external files.
Reject absolute and volume-based branding asset paths in the HTTP adapter. Add route tests to keep asset serving aligned with delete path validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add containsPathTraversal check in DeleteLogo and DeleteFavicon, mirroring the same guard already present in resolveBrandingAssetPath for asset serving.