fix(auth): show --allow-insecure hint in HTTPS cookie errors#1087
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the auth/config error flow so HTTPS-required cookie errors surface a UI-friendly message that includes guidance to use --allow-insecure for trusted plain-HTTP setups.
Changes:
- Adds a new localized error template for HTTPS-required auth cookies that includes the
--allow-insecurehint. - Updates auth routes to emit the new error template for
ErrHTTPSRequired. - Enhances the UI config loader to map localized API error objects into a readable message (and adds an e2e test to prevent
[object Object]regressions).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ui/leafwiki-ui/src/locales/en/errors.json | Adds the new English translation key used by the backend error template. |
| ui/leafwiki-ui/src/lib/api/config.ts | Maps localized error responses from /api/config into a user-facing message string. |
| internal/wiki/auth/routes.go | Switches HTTPS cookie error template to the new key so the UI can display the --allow-insecure hint. |
| e2e/tests/auth.spec.ts | Adds regression coverage ensuring config errors show the hint and never display [object Object]. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
perber
force-pushed
the
fix/https-cookie-error-message
branch
from
May 31, 2026 15:54
cff3acd to
6858c59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.