Repository navigation
feat: add OllamaBuilder; deprecate host+port constructors - #336
Merged
pepperoni21 merged 1 commit intoJun 3, 2026
Merged
Conversation
Owner
|
Hi, thanks for doing it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136
Adds
OllamaBuilderwith.host(),.port(),.url(),.reqwest_client(),.request_headers()(under theheadersfeature) and.build(), plus anOllama::builder()shortcut. MarksOllama::newandOllama::new_with_clientas#[deprecated]since they were the awkwardhost + portpair called out in #135.Defaults match
Ollama::default()(http://127.0.0.1:11434, freshreqwest::Client, empty header map). Lefttry_new,from_url,From<Url>andDefaultalone since they aren't redundant with the builder, but happy to deprecate those too if you'd prefer one path in.The deprecation
sinceis set to0.3.5as a guess at the next release; feel free to bump if it lands under a different version.