reduce cloning in GuaranteeRewriter#1
Merged
pepijnve merged 1 commit intopepijnve:guaranteesfrom Nov 19, 2025
Merged
Conversation
pepijnve
reviewed
Nov 19, 2025
|
|
||
| fn rewrite_between( | ||
| between: &Between, | ||
| between: Between, |
Owner
There was a problem hiding this comment.
This is a style I would intuitively be inclined to avoid since it's pass-by-value both on the way in and on the way out. Does the Rust compiler guarantee that this gets optimised away?
Author
There was a problem hiding this comment.
That is a good question -- I don't know but I doubt it (the whole struct will be copied)
I think it my mind the benefit is that doing so saves the (potentially deep) cloning of the arguments
Owner
There was a problem hiding this comment.
True, clone is a deep copy while pass by value is shallow
pepijnve
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GuaranteeRewriterto datafusion_expr apache/datafusion#18821This is the same as apache#18823, but targets @pepijnve 's branch