Skip to content

Conversation

@anfanik
Copy link
Collaborator

@anfanik anfanik commented Feb 20, 2025

This PR fixes sendVideo test

@anfanik anfanik requested a review from pengrad February 20, 2025 13:14
@pengrad
Copy link
Owner

pengrad commented Feb 20, 2025

Nice! I was fixing it as well. Also want to remove PLATFORM_CLASS_MAPPED_TO_KOTLIN using width as JavaInteger

@pengrad pengrad merged commit fc172a2 into master Feb 20, 2025
1 check passed
@pengrad pengrad deleted the v8.3-send-video-test branch February 20, 2025 13:18
@anfanik
Copy link
Collaborator Author

anfanik commented Feb 20, 2025

Nice! I was fixing it as well. Also want to remove PLATFORM_CLASS_MAPPED_TO_KOTLIN using width as JavaInteger

I forgot to change return types of width(), height() and duration() functions. Change their type to JavaInteger 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants