Fix invalid type assertion in LoadBytes (#733)

moorereason · web-flow · commit fed146406641 · 2022-01-05T09:17:32.000-05:00
Fixes #732
diff --git a/marshal_test.go b/marshal_test.go
@@ -4119,3 +4119,13 @@ ErrorField = "foo"
 		t.Fatalf("error was expected")
 	}
 }
+
+func TestGithubIssue732(t *testing.T) {
+	var v interface{}
+	data := []byte("a=\nb=0")
+
+	err := Unmarshal(data, &v)
+	if err == nil {
+		t.Fatalf("error was expected")
+	}
+}
diff --git a/toml.go b/toml.go
@@ -471,7 +471,7 @@ func LoadBytes(b []byte) (tree *Tree, err error) {
 			if _, ok := r.(runtime.Error); ok {
 				panic(r)
 			}
-			err = errors.New(r.(string))
+			err = fmt.Errorf("%s", r)
 		}
 	}()
 

Original file line number	Diff line number	Diff line change
`@@ -4119,3 +4119,13 @@ ErrorField = "foo"`
`4119`	`4119`	`t.Fatalf("error was expected")`
`4120`	`4120`	`}`
`4121`	`4121`	`}`
	`4122`	`+`
	`4123`	`+func TestGithubIssue732(t *testing.T) {`
	`4124`	`+ var v interface{}`
	`4125`	`+ data := []byte("a=\nb=0")`
	`4126`	`+`
	`4127`	`+ err := Unmarshal(data, &v)`
	`4128`	`+ if err == nil {`
	`4129`	`+ t.Fatalf("error was expected")`
	`4130`	`+ }`
	`4131`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -471,7 +471,7 @@ func LoadBytes(b []byte) (tree *Tree, err error) {`
`471`	`471`	`if _, ok := r.(runtime.Error); ok {`
`472`	`472`	`panic(r)`
`473`	`473`	`}`
`474`		`- err = errors.New(r.(string))`
	`474`	`+ err = fmt.Errorf("%s", r)`
`475`	`475`	`}`
`476`	`476`	`}()`
`477`	`477`