Conversation
|
I agree, we should definitely merge the code changes (not the synonyms which are Portland specific). I think with https://github.com/pelias/schema/tree/disable_fielddata, which I have tested using https://github.com/orangejulius/ci-test and appears to perform identically for Portland, we should be able to now run fairly large builds on our local machines. Want to plan to merge these code changes after comparing the results on a North America or Europe build? |
|
Thanks to pelias/docker#23 I can now confirm that this PR and #310 perform identically when used in the |
orangejulius
force-pushed
the
portland-synonyms
branch
3 times, most recently
from
0b55fd0 to
89a848b
Compare
orangejulius
force-pushed
the
portland-synonyms
branch
from
89a848b to
e3ea52b
Compare
orangejulius
force-pushed
the
portland-synonyms
branch
from
e3ea52b to
4c503d8
Compare
|
All generally relevant code for this PR has now been merged in #310, so this PR is no longer needed. |
2 participants
@orangejulius we need to decide what to do with this code, I would suggest we merge it, but I'm not sure what the effect would be, in particular the following changes make me nervous:
despite the changes, we should try to get this published, it was tested on a smaller extract and had a positive impact.
how would you like to handle merging, testing and deploying this?
[minor] looks like
RUN npm testwas removed from the dockerfile and the format was changed