Add multi_match leaf query function#114
Merged
orangejulius merged 1 commit intomasterfrom Nov 7, 2019
Merged
Conversation
orangejulius
approved these changes
Nov 7, 2019
Member
orangejulius
left a comment
orangejulius
left a comment
There was a problem hiding this comment.
Nice, thanks. This is a really complicated query type to support but I suspect we'll be using it more and more over time.
| 'cross_fields': ['analyzer', 'boost', 'operator', 'minimum_should_match', 'lenient', 'zero_terms_query', 'cutoff_frequency'], | ||
| 'phrase': PHRASE_PARAMS, | ||
| 'phrase_prefix': PHRASE_PARAMS.concat('max_expansions') | ||
| }; |
Member
Author
|
Yes, I tried to support all ES parameters 😁 |
Joxit
added a commit
to pelias/api
that referenced
this pull request
Nov 8, 2019
Joxit
added a commit
to pelias/api
that referenced
this pull request
Nov 8, 2019
orangejulius
pushed a commit
to pelias/api
that referenced
this pull request
May 25, 2020
Joxit
added a commit
to pelias/api
that referenced
this pull request
Jun 4, 2020
orangejulius
pushed a commit
to pelias/api
that referenced
this pull request
Jun 26, 2020
orangejulius
pushed a commit
to pelias/api
that referenced
this pull request
Jun 26, 2020
orangejulius
added a commit
that referenced
this pull request
Aug 26, 2020
BREAKING CHANGE: the old multi_match view is removed. I don't remembe writing it, but since #14 in early 2016(!) we have had a general purpose view for [multi_match](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-multi-match-query.html) queries. This view doesn't fit our current pattern for keeping general purpose (i.e. corresponding to built in Elasticsear query) views in the `view/leaf` directory, and it doesn't support as much functionality as the `multi_match` view @Joxit made for us in #114 last year. This PR removes the older view, and in the process converts the `admin_multi_match` view over to using the new `multi_match` leaf query. While I don't think anything in the Pelias API uses the old `multi_match` query directly, this removal will require changes to the API tests because of minor differences in the final output.
orangejulius
added a commit
that referenced
this pull request
Aug 26, 2020
BREAKING CHANGE: the old multi_match view is removed. I don't remember writing it, but since #14 in early 2016(!) we have had a general purpose view for [multi_match](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-multi-match-query.html) queries. This view doesn't fit our current pattern for keeping general purpose (i.e. corresponding to built in Elasticsearch query) views in the `view/leaf` directory, and it doesn't support as much functionality as the `multi_match` view @Joxit made for us in #114 last year. This PR removes the older view, and in the process converts the `admin_multi_match` view over to using the new `multi_match` leaf query. While I don't think anything in the Pelias API uses the old `multi_match` query directly, this removal will require changes to the API tests because of minor differences in the final output.
orangejulius
added a commit
that referenced
this pull request
Aug 26, 2020
BREAKING CHANGE: the old multi_match view is removed. I don't remember writing it, but since #14 in early 2016(!) we have had a general purpose view for [multi_match](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-multi-match-query.html) queries. This view doesn't fit our current pattern for keeping general purpose (i.e. corresponding to built in Elasticsearch query) views in the `view/leaf` directory, and it doesn't support as much functionality as the `multi_match` view @Joxit made for us in #114 last year. This PR removes the older view, and in the process converts the `admin_multi_match` view over to using the new `multi_match` leaf query. While I don't think anything in the Pelias API uses the old `multi_match` query directly, this removal will require changes to the API tests because of minor differences in the final output.
bboure
pushed a commit
to tamaringoapp/api
that referenced
this pull request
Sep 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I follow #109 with the multi_match in leaf query.
I think this will be useful for the multi-lang support, it will simplify queries in the API.
Connected pelias/api#1300