fix(lib): Ensure match and match_phrase handle empty Variables#112
Merged
orangejulius merged 1 commit intomasterfrom Oct 3, 2019
Merged
fix(lib): Ensure match and match_phrase handle empty Variables#112orangejulius merged 1 commit intomasterfrom
orangejulius merged 1 commit intomasterfrom
Conversation
We want the match and match_phrase helper functions to gracefully handle the case where a variable has no value, which internally is an empty string. This requires doing an explicit comparison to ensure that optional parameters are not set unless the variable is actually defined.
orangejulius
added a commit
that referenced
this pull request
Oct 3, 2019
This change builds on the previous series of PRs (#112, and #111) to support the `slop` parameter on the `match_phrase` queries responsible for handling street addresses. Replaces #101 Connects pelias/api#1322
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want the match and match_phrase helper functions to gracefully handle the case where a variable has no value, which internally is an empty string.
This requires doing an explicit comparison to ensure that optional parameters are not set unless the variable is actually defined.