fix: do not fire webhook for unregistered tokens (#23)#24
Merged
Conversation
![clap [bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
Co-Authored-By: Claude Opus 4.6 <[email protected]>
peg
pushed a commit
that referenced
this pull request
Mar 24, 2026
Mirrors the fix applied to the Go server in #24. When a token hits /c/{token} but has no KV registration, the global WEBHOOK_URLS fallback was still firing — causing false alerts from probe traffic hitting partial URLs like /c/agent-01-. resolveWebhooks() now returns a 'registered' flag; processAlert() returns early for unregistered tokens (except snare-test-* tokens which are exempt by design).
peg
added a commit
that referenced
this pull request
Mar 25, 2026
* fix: replace example AWS account ID with canonical 123456789012 * fix(worker): do not fire webhook for unregistered tokens Mirrors the fix applied to the Go server in #24. When a token hits /c/{token} but has no KV registration, the global WEBHOOK_URLS fallback was still firing — causing false alerts from probe traffic hitting partial URLs like /c/agent-01-. resolveWebhooks() now returns a 'registered' flag; processAlert() returns early for unregistered tokens (except snare-test-* tokens which are exempt by design). * fix(worker): polish items for v0.1.4 - Update alert footer to 'IP, UA, timestamp only — no request body' - Log test callbacks as CANARY_TEST vs CANARY_FIRED - Add missing canary types: huggingface, azure, git, terraform - Add v0.1.4 CHANGELOG entry --------- Co-authored-by: clap [bot] <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23.
In
processAlert, whendb.getTokenreturnsnil(token not registered), the global fallback webhook was still fired. This caused false alerts from probe traffic hitting partial/random token URLs.Fix: early return after inserting the event if
reg == nil. Event is still recorded for audit, but no webhook fires.