fix: darwin build — split terminal raw mode into platform files#17
Merged
Conversation
![clap [bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
syscall.TCGETS/TCSETS are Linux-only — darwin build failed in CI. Split into terminal_linux.go, terminal_darwin.go, terminal_other.go. darwin uses TIOCGETA/TIOCSETA ioctl constants instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI failed on darwin/amd64 and darwin/arm64:
syscall.TCGETS/TCSETSare Linux-only constants.Split terminal raw mode into platform-specific files:
terminal_linux.go— usesTCGETS/TCSETSterminal_darwin.go— usesTIOCGETA/TIOCSETAterminal_other.go— stub returning an error for unsupported platformsVerified:
go buildpasses on linux/amd64, darwin/amd64, darwin/arm64.