Repository navigation
fix(web): resolve parsed Windows file links - #1
Draft
carlosesl1 wants to merge 1 commit into
Draft
carlosesl1 wants to merge 1 commit into
carlosesl1 wants to merge 1 commit into
Conversation
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The upstream PR preserves direct Windows drive links through sanitization, but
ChatMarkdownstill classifies file links from a raw-text regex before rendering. Valid Markdown destinations such as<C:/Users/Carlos/My Project/docs/Plan (final).md>are parsed by React Markdown but missed by that regex, so the precomputed metadata lookup is empty and the rendered link falls through to the ordinary external-anchor path.Fix
hrefdirectly when the precomputed raw-Markdown lookup misses.This is intentionally a small follow-up to pingdotgg#6237 and covers the reproduction documented in pingdotgg#5158.
Verification
vp test run src/markdown-links.test.ts src/markdown-links-rendering.test.tsx --project unit— 43 tests passedpnpm --filter @t3tools/web typecheckvp lintandvp fmt --checkfor the four changed filesNo visual styling changes; this only routes already-rendered file links through the existing file-link behavior.
Implemented with GPT-5.6 Sol in T3 Code via the Codex harness.