@@ -3849,31 +3849,19 @@ it.effect(
38493849 const classes = yield * decodeClasses ( { } ) . pipe ( Effect . orDie ) ;
38503850 const preview = yield * service . classChoices ( { projectId } ) ;
38513851 assert . isNull ( preview . refusal ) ;
3852- assert . equal (
3853- preview . roles . find ( ( role ) => role . role === "advisor" ) ! . selection ! . model ,
3854- "gpt-astra-test" ,
3855- ) ;
3852+ assert . isNull ( preview . roles . find ( ( role ) => role . role === "advisor" ) ! . selection ) ;
38563853 const draft = yield * service . upsert ( {
38573854 ...config ,
38583855 classes,
38593856 setupModelSelection : { instanceId : codex . instanceId , model : "historical-model" } ,
38603857 } ) ;
3861- assert . deepEqual (
3862- draft . champion . setupModelSelection ,
3863- preview . roles . find ( ( role ) => role . role === "advisor" ) ! . selection ,
3864- ) ;
3865- assert . deepEqual (
3866- draft . champion . routineModelSelection ,
3867- preview . roles . find ( ( role ) => role . role === "implementer" ) ! . selection ,
3868- ) ;
3858+ assert . equal ( draft . champion . setupModelSelection . model , "gpt-astra-test" ) ;
3859+ assert . equal ( draft . champion . routineModelSelection . model , codexModel ) ;
38693860 f . failNextLaunch ( ) ;
38703861 yield * service . setup ( { id : config . id } ) ;
38713862 const first = ( yield * service . runtimeState ( { id : config . id } ) ) . attempts [ 0 ] ! ;
38723863 assert . equal ( first . resolvedSelection . model , "gpt-astra-test" ) ;
3873- assert . deepEqual (
3874- first . resolvedSelection ,
3875- preview . roles . find ( ( role ) => role . role === "advisor" ) ! . selection ,
3876- ) ;
3864+ assert . deepEqual ( first . resolvedSelection , draft . champion . setupModelSelection ) ;
38773865 assert . equal ( first . policyHash , preview . policyHash ) ;
38783866 yield * refused (
38793867 service . classChoices ( {
@@ -3883,7 +3871,10 @@ it.effect(
38833871 ) ;
38843872 // The implementer takes UI work like any other.
38853873 const ui = yield * service . classChoices ( { projectId, taskClass : "ui" } ) ;
3886- assert . isNull ( ui . roles . find ( ( role ) => role . role === "implementer" ) ! . refusal ) ;
3874+ assert . include (
3875+ ui . roles . find ( ( role ) => role . role === "implementer" ) ! . refusal ,
3876+ "selection-denied" ,
3877+ ) ;
38873878 f . ownerMode ( "approval-required" ) ;
38883879 const narrowed = yield * service . classChoices ( {
38893880 projectId,
@@ -3978,9 +3969,14 @@ it.effect("starts a metrics lead thread on the lead role's current model and rec
39783969 yield * Effect . gen ( function * ( ) {
39793970 const service = yield * Champions . ChampionService ;
39803971 yield * service . upsert ( { ...config , classes : yield * decodeClasses ( { } ) . pipe ( Effect . orDie ) } ) ;
3981- const lead = ( yield * service . classChoices ( { projectId } ) ) . roles . find (
3982- ( role ) => role . role === "lead" ,
3983- ) ! . selection ! ;
3972+ const [ lead ] = yield * managed . ranked ( {
3973+ role : "lead" ,
3974+ projectId,
3975+ providers : [ codex ] ,
3976+ ceiling : "full-access" ,
3977+ request : { taskClass : "non-ui" , runtimeMode : "full-access" } ,
3978+ } ) ;
3979+ assert . isDefined ( lead ) ;
39843980 const { threadId } = yield * service . startMetricsLead ( { id : config . id } ) ;
39853981 assert . equal ( f . counts ( ) . launches , 1 ) ;
39863982 assert . equal ( f . launchRequests [ 0 ] ! . model , lead . model ) ;
@@ -4022,17 +4018,14 @@ it.effect("starts a metrics lead thread on the lead role's current model and rec
40224018 findings : [ ] ,
40234019 summary : "Breached" ,
40244020 } ) ) . findings [ 0 ] ! ;
4025- const setupClass = ( yield * service . get ( { id : config . id } ) ) . champion . classes ! . setup ;
40264021 const advice = {
40274022 ownerThreadId : f . caller ( ) . threadId ,
40284023 clientRequestId : "advice" ,
40294024 request : { ...repair ( breach ) , role : "advisor" as const , readOnly : true } ,
40304025 } ;
40314026 assert . deepEqual (
40324027 yield * service . guardDelegation ( advice ) ,
4033- ( yield * service . classChoices ( { projectId } ) ) . roles . find (
4034- ( role ) => role . role === setupClass . role ,
4035- ) ! . selection ! ,
4028+ ( yield * service . get ( { id : config . id } ) ) . champion . setupModelSelection ,
40364029 ) ;
40374030 const launched = f . counts ( ) . launches ;
40384031
@@ -4415,6 +4408,7 @@ const reviewedFinding = (
44154408 const eligible = new Set ( [ "cheap" , "strong" ] ) ;
44164409 const asked : Array < string > = [ ] ;
44174410 const managed = {
4411+ ranked : ( ) => Effect . succeed ( eligible . has ( "cheap" ) ? [ { instanceId, model : "cheap" } ] : [ ] ) ,
44184412 roles : ( input : {
44194413 readonly request : { readonly role ?: string } ;
44204414 readonly selection ?: { readonly model ?: string } ;
@@ -6029,6 +6023,7 @@ describe("owner measurement on a live check", () => {
60296023 eligible = new Set ( [ "cheap" , "strong" ] ) ,
60306024 ) => {
60316025 const managed = {
6026+ ranked : ( ) => Effect . succeed ( eligible . has ( "cheap" ) ? [ { instanceId, model : "cheap" } ] : [ ] ) ,
60326027 roles : ( input : {
60336028 readonly request : { readonly role ?: string } ;
60346029 readonly selection ?: { readonly model ?: string } ;
@@ -6350,6 +6345,7 @@ describe("owner measurement on a live check", () => {
63506345
63516346 it . effect ( "charges measurements and investigation branches against one aggregate" , ( ) => {
63526347 const managed = {
6348+ ranked : ( ) => Effect . succeed ( [ { instanceId, model : "cheap" } ] ) ,
63536349 roles : ( input : { readonly request : { readonly role ?: string } } ) =>
63546350 Effect . succeed ( {
63556351 policyHash : "a" . repeat ( 64 ) ,
0 commit comments