Booklet ordering - public method #817
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hello! |
Contributor
Author
|
sounds good. no rush.
…On Sun, Mar 3, 2024 at 1:41 PM Horst Rutter ***@***.***> wrote:
Hello!
I am about to cut a release so there is a code freeze in effect as far as
PRs.
I need to get back to you about this in order to gain a better
understanding about the purpose of this PR.
Talk to you later!
—
Reply to this email directly, view it on GitHub
<#817 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFMDF6QB7LZHWULQSN36W3YWOKKBAVCNFSM6AAAAABEEGSPPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZVGM3DQNJVGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Collaborator
|
Hi Adam, |
Contributor
Author
|
They have not changed - just run tests and committed results to confirm.
…On Mon, Mar 25, 2024 at 6:31 AM Horst Rutter ***@***.***> wrote:
Hi Adam,
Do we also need to merge in the generated PDF files which are part of this?
Have they changed?
—
Reply to this email directly, view it on GitHub
<#817 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFMDF7RC42MR55IHIWYJFLY2ARMRAVCNFSM6AAAAABEEGSPPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJYGAYTKOJUGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Collaborator
|
ok then, I am gonna leave them out to avoid unnecessary repo size bloat. |
Collaborator
|
This is merged in ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#816
I want to use the booklet ordering (currently internal to pdfcpu) somewhere else in my code.
to do this, I rearranged the
multifoliocode and added some test casesI also tweaked the cli description of
multifolio- I'm much more familiar calling this concept "signatures"