Avoid duplicate keyword search #1066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Sounds very cool.. |
hhrutter
reviewed
Jan 16, 2025
| line := string(buf) | ||
|
|
||
| endInd, streamInd, err = model.DetectKeywords(line) | ||
| endInd, streamInd, err = model.DetectKeywordsWithContext(c, line) |
Collaborator
There was a problem hiding this comment.
Why don't we leave the original method name DetectKeywords and pass in as 2nd parm the context from the caller. does that make any sense?
hhrutter
reviewed
Jan 16, 2025
Collaborator
hhrutter
left a comment
hhrutter
left a comment
There was a problem hiding this comment.
There is a(n old) bug in posFloor:
if pos1 < pos2 {
return pos2
}
should be
if pos1 < pos2 {
return pos1
}
Collaborator
|
Happy to merge if you can take care of these 2 issues. |
|
@fancycode ping |
hhrutter
force-pushed
the
avoid-duplicate-keyword-search
branch
from
1d7b124 to
d94329a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1057
The example file contains a huge object with this content:
This blows up the parsing code in
pdfcpu/pkg/pdfcpu/model/parse.go
Line 1243 in 4e0e0db
Here the keywords are searched lots of times after the start is advanced for each string literal inside the array (e.g.
(node00000002), etc.).The PR fixes this by searching only once for the keywords and then adjusting the position if strings / comments are found before them. In my tests the example file now parses in about 3 seconds.