Fix #1149

hhrutter · hhrutter · commit f6312869d058 · 2025-05-08T10:45:58.000+02:00
diff --git a/offline_coverage.sh b/offline_coverage.sh
@@ -0,0 +1,48 @@
+#!/bin/sh
+
+# Copyright 2018 The pdfcpu Authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#	http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+rm c.out
+
+set -e
+
+echo mode: set > c.out
+
+function internalDeps {
+
+    for p in $(go list -f '{{.Deps}}' $1)
+    do
+        if [[ $p == github.com/pdfcpu/pdfcpu* ]]; then
+            idep=$idep,$p 
+        fi
+    done
+}
+
+echo collecting coverage ...
+
+for q in $(go list ./...)
+do
+    #echo collecting coverage for $q
+    idep=$q
+    internalDeps $idep
+    if [[ $q == */test ]]; then
+        idep=${idep%/test}
+    fi
+    GITHUB_ACTIONS="true" go test -coverprofile=c1.out -coverpkg=$idep $q && tail -n +2 c1.out  >> c.out
+done
+
+rm c1.out
+
+go tool cover -html=c.out
diff --git a/pkg/pdfcpu/createTestPDF.go b/pkg/pdfcpu/createTestPDF.go
@@ -34,13 +34,25 @@ var (
 )
 
 func CreateXRefTableWithRootDict() (*model.XRefTable, error) {
+	// TODO
+	//xRefTable := model.NewXRefTable(nil)
 	xRefTable := &model.XRefTable{
-		Table:      map[int]*model.XRefTableEntry{},
-		Names:      map[string]*model.Node{},
-		PageAnnots: map[int]model.PgAnnots{},
-		Stats:      model.NewPDFStats(),
-		URIs:       map[int]map[string]string{},
-		UsedGIDs:   map[string]map[uint16]bool{},
+		Table:             map[int]*model.XRefTableEntry{},
+		Names:             map[string]*model.Node{},
+		NameRefs:          map[string]model.NameMap{},
+		KeywordList:       types.StringSet{},
+		Properties:        map[string]string{},
+		LinearizationObjs: types.IntSet{},
+		PageAnnots:        map[int]model.PgAnnots{},
+		PageThumbs:        map[int]types.IndirectRef{},
+		Signatures:        map[int]map[int]model.Signature{},
+		Stats:             model.NewPDFStats(),
+		ValidationMode:    model.ValidationRelaxed,
+		ValidateLinks:     false,
+		URIs:              map[int]map[string]string{},
+		UsedGIDs:          map[string]map[uint16]bool{},
+		FillFonts:         map[string]types.IndirectRef{},
+		Conf:              nil,
 	}
 
 	xRefTable.Table[0] = model.NewFreeHeadXRefTableEntry()
diff --git a/pkg/pdfcpu/model/xreftable.go b/pkg/pdfcpu/model/xreftable.go
@@ -188,6 +188,7 @@ type XRefTable struct {
 }
 
 // NewXRefTable creates a new XRefTable.
+// TODO Export
 func newXRefTable(conf *Configuration) (xRefTable *XRefTable) {
 	return &XRefTable{
 		Table:             map[int]*XRefTableEntry{},

Original file line number	Diff line number	Diff line change
`@@ -188,6 +188,7 @@ type XRefTable struct {`
`188`	`188`	`}`
`189`	`189`
`190`	`190`	`// NewXRefTable creates a new XRefTable.`
	`191`	`+// TODO Export`
`191`	`192`	`func newXRefTable(conf Configuration) (xRefTable XRefTable) {`
`192`	`193`	`return &XRefTable{`
`193`	`194`	`Table: map[int]*XRefTableEntry{},`