Fix #931

hhrutter · hhrutter · commit ee932c43d1cd · 2024-08-25T08:54:24.000+02:00
diff --git a/pkg/pdfcpu/page.go b/pkg/pdfcpu/page.go
@@ -193,6 +193,27 @@ func addPages(
 	return nil
 }
 
+func migrateNamedDests(ctxSrc *model.Context, n *model.Node, migrated map[int]int) error {
+	patchValues := func(xRefTable *model.XRefTable, k string, v *types.Object) error {
+		arr, err := xRefTable.DereferenceArray(*v)
+		if err == nil {
+			arr[0] = patchObject(arr[0], migrated)
+			*v = arr
+			return nil
+		}
+		d, err := xRefTable.DereferenceDict(*v)
+		if err != nil {
+			return err
+		}
+		arr = d.ArrayEntry("D")
+		arr[0] = patchObject(arr[0], migrated)
+		*v = d
+		return nil
+	}
+
+	return n.Process(ctxSrc.XRefTable, patchValues)
+}
+
 // AddPages adds pages and corresponding resources from ctxSrc to ctxDest.
 func AddPages(ctxSrc, ctxDest *model.Context, pageNrs []int, usePgCache bool) error {
 
@@ -230,5 +251,13 @@ func AddPages(ctxSrc, ctxDest *model.Context, pageNrs []int, usePgCache bool) er
 		ctxDest.RootDict["AcroForm"] = d
 	}
 
+	if n, ok := ctxSrc.Names["Dests"]; ok {
+		// Carry over used named destinations.
+		if err := migrateNamedDests(ctxSrc, n, migrated); err != nil {
+			return err
+		}
+		ctxDest.Names = map[string]*model.Node{"Dests": n}
+	}
+
 	return nil
 }
