Fix #844

hhrutter · hhrutter · commit d568466bbb89 · 2024-04-09T01:49:07.000+02:00
diff --git a/pkg/api/api.go b/pkg/api/api.go
@@ -155,13 +155,20 @@ func ReadAndValidate(rs io.ReadSeeker, conf *model.Configuration) (ctx *model.Co
 	return ctx, nil
 }
 
-// ReadValidateAndOptimize returns an optimized model.Context of rs ready for processing.
+// ReadValidateAndOptimize returns an optimized model.Context of rs ready for processing a specific command.
+// conf.Cmd is expected to be configured properly.
 func ReadValidateAndOptimize(rs io.ReadSeeker, conf *model.Configuration) (ctx *model.Context, err error) {
+	if conf == nil {
+		return nil, errors.New("pdfcpu: ReadValidateAndOptimize: missing conf")
+	}
+
 	ctx, err = ReadAndValidate(rs, conf)
 	if err != nil {
 		return nil, err
 	}
 
+	// With the exception of the OPTIMIZE command optimization of the cross reference table is optional but usually recommended.
+	// For large or complex files it may make sense to skip optimization.
 	if conf.Cmd == model.OPTIMIZE || conf.Optimize {
 		if err = OptimizeContext(ctx); err != nil {
 			return nil, err
@@ -197,7 +204,6 @@ func Write(ctx *model.Context, w io.Writer, conf *model.Configuration) error {
 }
 
 func WriteIncr(ctx *model.Context, rws io.ReadWriteSeeker, conf *model.Configuration) error {
-
 	if log.StatsEnabled() {
 		log.Stats.Printf("XRefTable:\n%s\n", ctx)
 	}
diff --git a/pkg/api/extract.go b/pkg/api/extract.go
@@ -218,8 +218,8 @@ func ExtractPages(rs io.ReadSeeker, outDir, fileName string, selectedPages []str
 
 	if conf == nil {
 		conf = model.NewDefaultConfiguration()
-		conf.Cmd = model.EXTRACTPAGES
 	}
+	conf.Cmd = model.EXTRACTPAGES
 
 	ctx, err := ReadValidateAndOptimize(rs, conf)
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -218,8 +218,8 @@ func ExtractPages(rs io.ReadSeeker, outDir, fileName string, selectedPages []str`
`218`	`218`
`219`	`219`	`if conf == nil {`
`220`	`220`	`conf = model.NewDefaultConfiguration()`
`221`		`- conf.Cmd = model.EXTRACTPAGES`
`222`	`221`	`}`
	`222`	`+ conf.Cmd = model.EXTRACTPAGES`
`223`	`223`
`224`	`224`	`ctx, err := ReadValidateAndOptimize(rs, conf)`
`225`	`225`	`if err != nil {`