Fix #676

hhrutter · hhrutter · commit b42e6eba47fa · 2023-08-21T13:00:33.000+02:00
diff --git a/pkg/pdfcpu/model/nameTree.go b/pkg/pdfcpu/model/nameTree.go
@@ -224,12 +224,12 @@ func (n *Node) HandleLeaf(xRefTable *XRefTable, k string, v types.Object, m Name
 			if err == nil {
 				break
 			}
-			if len(m) == 0 {
-				return err
-			}
 			if err != errNameTreeDuplicateKey {
 				return err
 			}
+			if len(m) == 0 {
+				return nil
+			}
 			kNew := k + "\x01"
 			dd, ok := m[kOrig]
 			if !ok {
diff --git a/pkg/pdfcpu/model/nameTree_test.go b/pkg/pdfcpu/model/nameTree_test.go
@@ -170,8 +170,8 @@ func destroyNameTree(t *testing.T, r *Node) {
 		t.Fatal("should not find Value for x")
 	}
 
-	if err := r.Add(nil, "c", types.StringLiteral("cvv"), nil, nil); err == nil {
-		t.Fatalf("update c:should trigger DuplicateKeyException")
+	if err := r.Add(nil, "c", types.StringLiteral("cvv"), nil, nil); err != nil {
+		t.Fatalf("update c:should not trigger DuplicateKeyException")
 	}
 
 	empty, ok, _ = r.Remove(nil, "c")

Original file line number	Diff line number	Diff line change
`@@ -170,8 +170,8 @@ func destroyNameTree(t testing.T, r Node) {`
`170`	`170`	`t.Fatal("should not find Value for x")`
`171`	`171`	`}`
`172`	`172`
`173`		`- if err := r.Add(nil, "c", types.StringLiteral("cvv"), nil, nil); err == nil {`
`174`		`- t.Fatalf("update c:should trigger DuplicateKeyException")`
	`173`	`+ if err := r.Add(nil, "c", types.StringLiteral("cvv"), nil, nil); err != nil {`
	`174`	`+ t.Fatalf("update c:should not trigger DuplicateKeyException")`
`175`	`175`	`}`
`176`	`176`
`177`	`177`	`empty, ok, _ = r.Remove(nil, "c")`