Fix #760

hhrutter · hhrutter · commit 60e13f35c006 · 2024-01-29T22:57:30.000+01:00
diff --git a/pkg/pdfcpu/bookmark.go b/pkg/pdfcpu/bookmark.go
@@ -186,7 +186,16 @@ func BookmarksForOutlineItem(ctx *model.Context, item *types.IndirectRef, parent
 			return nil, err
 		}
 
-		s, _ := model.Text(d["Title"])
+		obj, err := ctx.Dereference(d["Title"])
+		if err != nil {
+			return nil, err
+		}
+
+		s, err := model.Text(obj)
+		if err != nil {
+			return nil, err
+		}
+
 		title := outlineItemTitle(s)
 
 		// Retrieve page number out of a destination via "Dest" or "Goto Action".
@@ -204,7 +213,7 @@ func BookmarksForOutlineItem(ctx *model.Context, item *types.IndirectRef, parent
 			dest = act.(types.Dict)["D"]
 		}
 
-		obj, err := ctx.Dereference(dest)
+		obj, err = ctx.Dereference(dest)
 		if err != nil {
 			return nil, err
 		}
diff --git a/pkg/pdfcpu/model/dereference.go b/pkg/pdfcpu/model/dereference.go
@@ -222,7 +222,7 @@ func Text(o types.Object) (string, error) {
 	case types.HexLiteral:
 		return types.HexLiteralToString(obj)
 	default:
-		return "", errors.Errorf("pdfcpu: text: corrupt -  %v\n", obj)
+		return "", errors.Errorf("pdfcpu: corrupt text: %v\n", obj)
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,7 @@ func Text(o types.Object) (string, error) {`
`222`	`222`	`case types.HexLiteral:`
`223`	`223`	`return types.HexLiteralToString(obj)`
`224`	`224`	`default:`
`225`		`- return "", errors.Errorf("pdfcpu: text: corrupt - %v\n", obj)`
	`225`	`+ return "", errors.Errorf("pdfcpu: corrupt text: %v\n", obj)`
`226`	`226`	`}`
`227`	`227`	`}`
`228`	`228`