Skip to content

Commit 79f3687

Browse files
committed
updated Mima to check against version 1.0
1 parent 1e8969c commit 79f3687

File tree

3 files changed

+5
-33
lines changed

3 files changed

+5
-33
lines changed

project/MimaBuild.scala

Lines changed: 3 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ object MimaBuild {
3131
// Read package-private excludes from file
3232
val excludeFilePath = (base.getAbsolutePath + "/.mima-excludes")
3333
val excludeFile = file(excludeFilePath)
34-
val packagePrivateList: Seq[String] =
34+
val ignoredClasses: Seq[String] =
3535
if (!excludeFile.exists()) {
3636
Seq()
3737
} else {
@@ -60,35 +60,9 @@ object MimaBuild {
6060
excludePackage("org.apache.spark." + packageName)
6161
}
6262

63-
val packagePrivateExcludes = packagePrivateList.flatMap(excludeClass)
63+
val externalExcludeFileClasses = ignoredClasses.flatMap(excludeClass)
6464

65-
/* Excludes specific to a given version of Spark. When comparing the given version against
66-
its immediate predecessor, the excludes listed here will be applied. */
67-
val versionExcludes =
68-
SparkBuild.SPARK_VERSION match {
69-
case v if v.startsWith("1.0") =>
70-
Seq(
71-
excludeSparkPackage("api.java"),
72-
excludeSparkPackage("mllib"),
73-
excludeSparkPackage("streaming")
74-
) ++
75-
excludeSparkClass("rdd.ClassTags") ++
76-
excludeSparkClass("util.XORShiftRandom") ++
77-
excludeSparkClass("graphx.EdgeRDD") ++
78-
excludeSparkClass("graphx.VertexRDD") ++
79-
excludeSparkClass("graphx.impl.GraphImpl") ++
80-
excludeSparkClass("graphx.impl.RoutingTable") ++
81-
excludeSparkClass("graphx.util.collection.PrimitiveKeyOpenHashMap") ++
82-
excludeSparkClass("graphx.util.collection.GraphXPrimitiveKeyOpenHashMap") ++
83-
excludeSparkClass("mllib.recommendation.MFDataGenerator") ++
84-
excludeSparkClass("mllib.optimization.SquaredGradient") ++
85-
excludeSparkClass("mllib.regression.RidgeRegressionWithSGD") ++
86-
excludeSparkClass("mllib.regression.LassoWithSGD") ++
87-
excludeSparkClass("mllib.regression.LinearRegressionWithSGD")
88-
case _ => Seq()
89-
}
90-
91-
defaultExcludes ++ packagePrivateExcludes ++ versionExcludes
65+
defaultExcludes ++ externalExcludeFileClasses
9266
}
9367

9468
def mimaSettings(sparkHome: File) = mimaDefaultSettings ++ Seq(

project/SparkBuild.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ import scala.collection.JavaConversions._
3232
// import com.jsuereth.pgp.sbtplugin.PgpKeys._
3333

3434
object SparkBuild extends Build {
35-
val SPARK_VERSION = "1.0.0-SNAPSHOT"
35+
val SPARK_VERSION = "1.1.0-SNAPSHOT"
3636
val SPARK_VERSION_SHORT = SPARK_VERSION.replaceAll("-SNAPSHOT", "")
3737

3838
// Hadoop version to build against. For example, "1.0.4" for Apache releases, or
@@ -321,7 +321,7 @@ object SparkBuild extends Build {
321321
val excludeServletApi = ExclusionRule(organization = "javax.servlet", artifact = "servlet-api")
322322

323323
def sparkPreviousArtifact(id: String, organization: String = "org.apache.spark",
324-
version: String = "0.9.0-incubating", crossVersion: String = "2.10"): Option[sbt.ModuleID] = {
324+
version: String = "1.0.0", crossVersion: String = "2.10"): Option[sbt.ModuleID] = {
325325
val fullId = if (crossVersion.isEmpty) id else id + "_" + crossVersion
326326
Some(organization % fullId % version) // the artifact to compare binary compatibility with
327327
}

project/project/SparkPluginBuild.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,10 @@ import sbt.Keys._
2626
object SparkPluginDef extends Build {
2727
lazy val root = Project("plugins", file(".")) dependsOn(sparkStyle)
2828
lazy val sparkStyle = Project("spark-style", file("spark-style"), settings = styleSettings)
29-
val sparkVersion = "1.0.0-SNAPSHOT"
3029
// There is actually no need to publish this artifact.
3130
def styleSettings = Defaults.defaultSettings ++ Seq (
3231
name := "spark-style",
3332
organization := "org.apache.spark",
34-
version := sparkVersion,
3533
scalaVersion := "2.10.4",
3634
scalacOptions := Seq("-unchecked", "-deprecation"),
3735
libraryDependencies ++= Dependencies.scalaStyle

0 commit comments

Comments
 (0)