Allow readonly before public/protected/private#673
Merged
kylekatarnls merged 1 commit intomasterfrom Aug 10, 2023
Merged
Conversation
kylekatarnls
force-pushed
the
fix/issue-665-readonly
branch
from
174be59 to
171a651
Compare
kylekatarnls
force-pushed
the
fix/issue-665-readonly
branch
from
171a651 to
228bcb5
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #673 +/- ##
=========================================
Coverage 82.08% 82.09%
- Complexity 3441 3443 +2
=========================================
Files 154 154
Lines 9467 9471 +4
=========================================
+ Hits 7771 7775 +4
Misses 1696 1696
☔ View full report in Codecov by Sentry. |
AJenbo
approved these changes
Aug 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: bugfix
Issue: Fix #665
Breaking change: no