Setup the signing of the phar file. Needed for Phive #397#663
Merged
AJenbo merged 2 commits intopdepend:masterfrom Apr 15, 2023
Merged
Setup the signing of the phar file. Needed for Phive #397#663AJenbo merged 2 commits intopdepend:masterfrom
AJenbo merged 2 commits intopdepend:masterfrom
Conversation
AJenbo
previously approved these changes
Apr 13, 2023
kylekatarnls
approved these changes
Apr 14, 2023
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #663 +/- ##
=========================================
Coverage 82.09% 82.09%
Complexity 3440 3440
=========================================
Files 154 154
Lines 9466 9466
=========================================
Hits 7771 7771
Misses 1695 1695 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
AJenbo
approved these changes
Apr 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: feature
Issue: #397
Breaking change: no
To be honest, I have use https://github.com/phpDocumentor/phar-ga as an example for signing the phar file 😃
@ravage84 If I'm correct you are currently the only one that can manage the secrets. Can you create/verify the secrets? I'm not sure if the key file has a PASSPHRASE.