Conversation
Keywords to describe pdepend Dev to let composer know the package is mostly a dev dependency, see: composer/composer#10960
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #657 +/- ##
=========================================
Coverage 82.09% 82.09%
Complexity 3440 3440
=========================================
Files 154 154
Lines 9466 9466
=========================================
Hits 7771 7771
Misses 1695 1695 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
@AJenbo The phpstan job failed on code I didn't changed. Does it mean we need to pin the PHPStan version or is there another reason? |
Yeah it's a down side with how we have things setup. PHPStan requires PHP 7.2 so we have it in the composer.json/lock file since it needs to allow for versions going all the way back to PHP 5.3. So instead we require it during CI (running on PHP 7.4). Right now it semi pinned because it will pull the last version that was installed from cache in most cases. I guess we could specify the given version in the composer command that installs it. |
|
Here is a fix for the detected issue: #658 You should be able to pin the PHPStan version by changing this from a range to an explicit version: |
Keywords to describe pdepend
Dev to let composer know the package is mostly a dev dependency, see: composer/composer#10960
Type: feature
Issue: -
Breaking change: no
With adding dev as keyword composer will suggest it as dev package if someone install it with composer require without --dev.
I found out it didn't had any keywords so I added some, maybe there are other keywords that make sense to add.