Base enum label validity on constant name rule#656
Conversation
kylekatarnls
force-pushed
the
fix/enum-keywords
branch
from
f068ef2 to
c1cd664
Compare
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #656 +/- ##
============================================
+ Coverage 82.07% 82.09% +0.01%
Complexity 3441 3441
============================================
Files 154 154
Lines 9469 9467 -2
============================================
Hits 7772 7772
+ Misses 1697 1695 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Hi, since this is merged, can the packaged get tagged so we can use it in phpmd? thanks! |
|
If you want to use the development branch ahead of release you can add it as a dependency with the version set to |
|
I get that, (don't like it :) ) but why not do new release with such a good fix? :) So, what is the release cycle? When can I expect this is released in a new tag? |
|
because it takes time to go through the process and make sure that everything is right. Volunteer, best effort. You can see historic times here https://github.com/pdepend/pdepend/tags to get a feel for it. |
6 participants
Drop token type filtering to simply check the token image.
As per
https://wiki.php.net/rfc/enumerations
https://www.php.net/manual/en/language.constants.php
Type: bugfix
Issue:
Breaking change: no