Skip to content

Numeric-strings#646

Merged
tvbeek merged 1 commit intopdepend:masterfrom
AJenbo:numeric-strings
Feb 18, 2023
Merged

Numeric-strings#646
tvbeek merged 1 commit intopdepend:masterfrom
AJenbo:numeric-strings

Conversation

@AJenbo
Copy link
Collaborator

@AJenbo AJenbo commented Feb 17, 2023

Type: refactoring / documentation
Breaking no

bcmath operates on numeric-strings and not integers/floats. This was correct in most places, this PR corrects the rest.

@codecov-commenter
Copy link

Codecov Report

Base: 82.26% // Head: 82.30% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (abf447b) compared to base (3d0f8d3).
Patch coverage: 93.75% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #646      +/-   ##
============================================
+ Coverage     82.26%   82.30%   +0.04%     
- Complexity     3548     3551       +3     
============================================
  Files           218      218              
  Lines          9692     9703      +11     
============================================
+ Hits           7973     7986      +13     
+ Misses         1719     1717       -2     
Impacted Files Coverage Δ
src/main/php/PDepend/Util/MathUtil.php 0.00% <ø> (ø)
.../PDepend/Source/Language/PHP/AbstractPHPParser.php 87.87% <90.90%> (+0.12%) ⬆️
...epend/Metrics/Analyzer/NPathComplexityAnalyzer.php 98.41% <100.00%> (ø)
src/main/php/PDepend/Util/IdBuilder.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AJenbo AJenbo mentioned this pull request Feb 17, 2023
@tvbeek tvbeek merged commit 88a5643 into pdepend:master Feb 18, 2023
@AJenbo AJenbo deleted the numeric-strings branch February 18, 2023 19:53
@ravage84 ravage84 added this to the 2.x (unspecific) milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants