Prevent the use of a not set id value in the AbstractASTType and AbstractASTCallable#637
Merged
ravage84 merged 2 commits intopdepend:masterfrom Feb 10, 2023
Conversation
…ractASTCallable. This prevent deprecated warning if null is passed to the storage driver.
kylekatarnls
previously approved these changes
Nov 30, 2022
AJenbo
approved these changes
Jan 24, 2023
tvbeek
deleted the
use_getId_function_and_not_id_variable_to_prevent_null
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent the use of a not set id value in the AbstractASTType and AbstractASTCallable
This prevent deprecated warning if null is passed to the storage driver.
Type: bugfix / refactoring
Issue: #.. the corresponding issue for this PR (if exist)
Breaking change: yes/no (if yes explain why)
I got the error:
Deprecated: substr(): Passing null to parameter #1 ($string) of type string is deprecated in /[project]/vendor/pdepend/pdepend/src/main/php/PDepend/Util/Cache/Driver/File/FileCacheDirectory.php on line 111While debugging I found out that it was from a call to the storage with null because the id wasn't set. By using the getId() function the id will be set if not yet done and it prevents errors more downstream the application.