Skip to content

Add support for NULL, DEFAULT and NEW as enum case.#636

Merged
AJenbo merged 2 commits intopdepend:masterfrom
tvbeek:635-special-enum-cases
Feb 9, 2023
Merged

Add support for NULL, DEFAULT and NEW as enum case.#636
AJenbo merged 2 commits intopdepend:masterfrom
tvbeek:635-special-enum-cases

Conversation

@tvbeek
Copy link
Member

@tvbeek tvbeek commented Nov 11, 2022

Type: bugfix
Issue: #635
Breaking change: no

This PR adds support for the NULL, DEFAULT and NEW enum case.

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2022

Codecov Report

Base: 82.38% // Head: 82.36% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (a44bbd8) compared to base (9b8b40f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #636      +/-   ##
============================================
- Coverage     82.38%   82.36%   -0.02%     
  Complexity     3540     3540              
============================================
  Files           218      218              
  Lines          9678     9680       +2     
============================================
  Hits           7973     7973              
- Misses         1705     1707       +2     
Impacted Files Coverage Δ
.../PDepend/Source/Language/PHP/AbstractPHPParser.php 87.74% <0.00%> (-0.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

AJenbo
AJenbo previously approved these changes Nov 11, 2022
kylekatarnls
kylekatarnls previously approved these changes Nov 15, 2022
@ravage84 ravage84 dismissed stale reviews from kylekatarnls and AJenbo via a44bbd8 November 16, 2022 12:38
@ravage84
Copy link
Member

@tvbeek thanks for the change. 😎

Why did you consider it a "bugfix", though?

Type: bugfix

@tvbeek
Copy link
Member Author

tvbeek commented Nov 16, 2022

@tvbeek thanks for the change. 😎

Why did you consider it a "bugfix", though?

Type: bugfix

Because I thought it was a bug because it didn't work with a PHP version we support., but it can also be support for a new PHP version. 😄

@ravage84 thanks for updating the PR.

@GErpeldinger
Copy link

Hi, when do you think it will be merged and deployed please?

@AJenbo AJenbo merged commit 3c59af7 into pdepend:master Feb 9, 2023
@AJenbo
Copy link
Collaborator

AJenbo commented Feb 9, 2023

There is not a fixed release schedule, but you can start using it by installing the latest development version

@tvbeek tvbeek deleted the 635-special-enum-cases branch February 25, 2023 19:42
@ravage84 ravage84 added this to the 2.x (unspecific) milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

6 participants