Skip to content

Fix parsing for new with parentheses#633

Merged
kylekatarnls merged 3 commits intomasterfrom
fix/issue-601-new-with-expression
Sep 21, 2022
Merged

Fix parsing for new with parentheses#633
kylekatarnls merged 3 commits intomasterfrom
fix/issue-601-new-with-expression

Conversation

@kylekatarnls
Copy link
Member

Type: bugfix
Issue: Fix #601 Fix phpmd/phpmd#952
Breaking change: no

@kylekatarnls kylekatarnls added this to the 2.13.0 milestone Sep 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Merging #633 (40474a6) into master (4870c10) will increase coverage by 0.01%.
The diff coverage is 93.75%.

@@             Coverage Diff              @@
##             master     #633      +/-   ##
============================================
+ Coverage     82.36%   82.38%   +0.01%     
- Complexity     3536     3540       +4     
============================================
  Files           218      218              
  Lines          9665     9678      +13     
============================================
+ Hits           7961     7973      +12     
- Misses         1704     1705       +1     
Impacted Files Coverage Δ
.../PDepend/Source/Language/PHP/AbstractPHPParser.php 87.81% <93.75%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kylekatarnls kylekatarnls merged commit 9b8b40f into master Sep 21, 2022
@kylekatarnls kylekatarnls deleted the fix/issue-601-new-with-expression branch September 21, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

PHP 8 new with arbitrary expressions leads to a syntax issue PHP 8 new with arbitrary expressions leads to a syntax issue

3 participants