Skip to content

Fix enum visit#631

Merged
kylekatarnls merged 1 commit intomasterfrom
fix/enum-visit
Sep 8, 2022
Merged

Fix enum visit#631
kylekatarnls merged 1 commit intomasterfrom
fix/enum-visit

Conversation

@kylekatarnls
Copy link
Member

Type: bugfix
Breaking change: no

@kylekatarnls kylekatarnls added this to the 2.12.1 milestone Sep 8, 2022
@kylekatarnls kylekatarnls self-assigned this Sep 8, 2022
@kylekatarnls kylekatarnls marked this pull request as ready for review September 8, 2022 19:17
@kylekatarnls kylekatarnls removed their assignment Sep 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Merging #631 (c4dca16) into master (c497786) will decrease coverage by 0.04%.
The diff coverage is 80.64%.

@@             Coverage Diff              @@
##             master     #631      +/-   ##
============================================
- Coverage     82.41%   82.36%   -0.05%     
- Complexity     3532     3536       +4     
============================================
  Files           218      218              
  Lines          9654     9665      +11     
============================================
+ Hits           7956     7961       +5     
- Misses         1698     1704       +6     
Impacted Files Coverage Δ
...p/PDepend/Source/ASTVisitor/AbstractASTVisitor.php 84.75% <50.00%> (-0.43%) ⬇️
...hp/PDepend/Metrics/Analyzer/ClassLevelAnalyzer.php 95.16% <82.75%> (-3.97%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kylekatarnls kylekatarnls merged commit d0cf581 into master Sep 8, 2022
@kylekatarnls kylekatarnls deleted the fix/enum-visit branch September 8, 2022 20:27
@alexndlm
Copy link

alexndlm commented Sep 9, 2022

@kylekatarnls with version 2.12.1 I have the following error:

PHP Fatal error:  Uncaught TypeError: PHPMD\Node\InterfaceNode::__construct(): Argument #1 ($node) must be of type PDepend\Source\AST\ASTInterface, PDepend\Source\AST\ASTEnum given

With version 2.12.0 - all ok.

@kylekatarnls
Copy link
Member Author

Hello, if you're getting this while using PHPMD, can you try:

composer require phpmd/phpmd:dev-master#4b5d37067ead4dc1ed66c2698fdd8edce2cf10a3

And tell if the result is different?

If not, can you provide the code you run?

@alexndlm
Copy link

alexndlm commented Sep 9, 2022

With 4b5d37067ead4dc1ed66c2698fdd8edce2cf10a3 works fine.

I will wait for the new phpmd release.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants