Skip to content

Fix parsing of by-reference vararg parameters#630

Merged
kylekatarnls merged 2 commits intopdepend:masterfrom
asmundstavdahl:master
Sep 6, 2022
Merged

Fix parsing of by-reference vararg parameters#630
kylekatarnls merged 2 commits intopdepend:masterfrom
asmundstavdahl:master

Conversation

@asmundstavdahl
Copy link
Contributor

@asmundstavdahl asmundstavdahl commented Sep 6, 2022

Type: bugfix
Issue: Fix #629
Breaking change: no

Fix the mentioned issue and add test code to confirm it.

@codecov-commenter
Copy link

Codecov Report

Merging #630 (44d49bf) into master (63a7459) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #630   +/-   ##
=========================================
  Coverage     82.40%   82.41%           
- Complexity     3531     3532    +1     
=========================================
  Files           218      218           
  Lines          9653     9654    +1     
=========================================
+ Hits           7955     7956    +1     
  Misses         1698     1698           
Impacted Files Coverage Δ
...PDepend/Source/Language/PHP/PHPParserVersion81.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kylekatarnls kylekatarnls added this to the 2.12.0 milestone Sep 6, 2022
@kylekatarnls kylekatarnls merged commit bb53810 into pdepend:master Sep 6, 2022
@kylekatarnls
Copy link
Member

Thank you, I'm adding it for the release of tomorrow.

kylekatarnls added a commit that referenced this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Mixed, by-reference varargs parameter gets handled like an intersection type and throws a fatal error

4 participants