Skip to content

Add tests for fetching properties of enums in const expressions#627

Merged
tvbeek merged 2 commits intomasterfrom
feature/php-8-2-enum-properties-in-const-expressions
Sep 5, 2022
Merged

Add tests for fetching properties of enums in const expressions#627
tvbeek merged 2 commits intomasterfrom
feature/php-8-2-enum-properties-in-const-expressions

Conversation

@kylekatarnls
Copy link
Member

Type: feature + tests
Issue: #617
Breaking change: yes/no (if yes explain why)

  • Add ASTNamespace::getEnums() methods
  • Add tests for fetching properties of enums in const expressions

@kylekatarnls kylekatarnls added this to the 2.12.0 milestone Sep 4, 2022
@kylekatarnls kylekatarnls mentioned this pull request Sep 4, 2022
5 tasks
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2022

Codecov Report

Merging #627 (d2fc0c7) into master (88d2e19) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #627      +/-   ##
============================================
- Coverage     82.42%   82.40%   -0.02%     
- Complexity     3530     3531       +1     
============================================
  Files           218      218              
  Lines          9651     9653       +2     
============================================
  Hits           7955     7955              
- Misses         1696     1698       +2     
Impacted Files Coverage Δ
src/main/php/PDepend/Source/AST/ASTNamespace.php 96.92% <0.00%> (-3.08%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kylekatarnls kylekatarnls force-pushed the feature/php-8-2-enum-properties-in-const-expressions branch from 57a68be to 3f7c285 Compare September 4, 2022 22:11
AJenbo
AJenbo previously approved these changes Sep 4, 2022
@kylekatarnls kylekatarnls requested a review from AJenbo September 5, 2022 07:28
@tvbeek tvbeek merged commit 63a7459 into master Sep 5, 2022
@tvbeek tvbeek deleted the feature/php-8-2-enum-properties-in-const-expressions branch September 5, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants