Skip to content

Fix ASTEnum serialization#622

Merged
tvbeek merged 1 commit intomasterfrom
fix/issue-621-enum-serialization
Sep 1, 2022
Merged

Fix ASTEnum serialization#622
tvbeek merged 1 commit intomasterfrom
fix/issue-621-enum-serialization

Conversation

@kylekatarnls
Copy link
Member

Type: bugfix
Issue: Fix #621
Breaking change: no

@kylekatarnls kylekatarnls added this to the 2.11.1 milestone Sep 1, 2022
@kylekatarnls kylekatarnls force-pushed the fix/issue-621-enum-serialization branch from cddd758 to 34d3834 Compare September 1, 2022 07:45
@kylekatarnls kylekatarnls marked this pull request as draft September 1, 2022 07:53
@kylekatarnls kylekatarnls force-pushed the fix/issue-621-enum-serialization branch from 34d3834 to b95b46f Compare September 1, 2022 08:31
@kylekatarnls kylekatarnls marked this pull request as ready for review September 1, 2022 08:32
@kylekatarnls kylekatarnls force-pushed the fix/issue-621-enum-serialization branch from b95b46f to 8d229e2 Compare September 1, 2022 08:34
@codecov-commenter
Copy link

Codecov Report

Merging #622 (b95b46f) into master (f1618de) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

❗ Current head b95b46f differs from pull request most recent head 8d229e2. Consider uploading reports for the commit 8d229e2 to get more accurate results

@@             Coverage Diff              @@
##             master     #622      +/-   ##
============================================
- Coverage     82.57%   82.51%   -0.07%     
- Complexity     3512     3514       +2     
============================================
  Files           217      217              
  Lines          9603     9610       +7     
============================================
  Hits           7930     7930              
- Misses         1673     1680       +7     
Impacted Files Coverage Δ
src/main/php/PDepend/Source/AST/ASTEnum.php 0.00% <0.00%> (ø)
...ce/Builder/BuilderContext/GlobalBuilderContext.php 88.46% <0.00%> (-11.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tvbeek tvbeek merged commit fe67640 into master Sep 1, 2022
@tvbeek tvbeek deleted the fix/issue-621-enum-serialization branch September 1, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

GlobalBuilderContext::registerClass() should accept ASTEnum class or an relevant interface.

3 participants