Skip to content

apu2/bootorder*: add entries for mPCIe1 SATA#36

Merged
mek-x merged 4 commits intopcengines:coreboot-4.0.xfrom
macpijan:mpcie-bootorder-legacy
May 31, 2017
Merged

apu2/bootorder*: add entries for mPCIe1 SATA#36
mek-x merged 4 commits intopcengines:coreboot-4.0.xfrom
macpijan:mpcie-bootorder-legacy

Conversation

@macpijan
Copy link
Copy Markdown
Member

No description provided.

@macpijan macpijan force-pushed the mpcie-bootorder-legacy branch from 8a77a24 to 43281e8 Compare May 30, 2017 12:11
@mek-x mek-x merged commit 98c5c8a into pcengines:coreboot-4.0.x May 31, 2017
Stojek139808 pushed a commit that referenced this pull request Jul 26, 2022
This micro optimization of using unsigned char instead of unsigned
integer actually generates one more instruction.

    .LVL296:                                                        .LVL296:
    .L198:                                                          .L198:
            .loc 1 912 16 is_stmt 1 discriminator 1 view .LVU1740           .loc 1 912 16 is_stmt 1 discriminator 1 view .LVU1740
            uxtb    r2, r3                                        |         cmp     r7, r3
            cmp     r7, r2                                        <
            bhi     .L199                                                   bhi     .L199
            .loc 1 916 1 is_stmt 0 view .LVU1741                            .loc 1 916 1 is_stmt 0 view .LVU1741
            add     sp, sp, #36                                             add     sp, sp, #36
            .cfi_remember_state                                             .cfi_remember_state
            .cfi_def_cfa_offset 20                                          .cfi_def_cfa_offset 20
            @ sp needed                                                     @ sp needed
            pop     {r4, r5, r6, r7, pc}                                    pop     {r4, r5, r6, r7, pc}

Fix it, so nobody can copy that.

Change-Id: If5ffeacc7ac3c53a82b260cfb81ef7debc40034a
Signed-off-by: Paul Menzel <[email protected]>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65731
Tested-by: build bot (Jenkins) <[email protected]>
Reviewed-by: Julius Werner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants