apu2/bootorder*: add entries for mPCIe1 SATA#36
Merged
mek-x merged 4 commits intopcengines:coreboot-4.0.xfrom May 31, 2017
Merged
apu2/bootorder*: add entries for mPCIe1 SATA#36mek-x merged 4 commits intopcengines:coreboot-4.0.xfrom
mek-x merged 4 commits intopcengines:coreboot-4.0.xfrom
Conversation
8a77a24 to
43281e8
Compare
pietrushnic
approved these changes
May 30, 2017
Stojek139808
pushed a commit
that referenced
this pull request
Jul 26, 2022
This micro optimization of using unsigned char instead of unsigned
integer actually generates one more instruction.
.LVL296: .LVL296:
.L198: .L198:
.loc 1 912 16 is_stmt 1 discriminator 1 view .LVU1740 .loc 1 912 16 is_stmt 1 discriminator 1 view .LVU1740
uxtb r2, r3 | cmp r7, r3
cmp r7, r2 <
bhi .L199 bhi .L199
.loc 1 916 1 is_stmt 0 view .LVU1741 .loc 1 916 1 is_stmt 0 view .LVU1741
add sp, sp, #36 add sp, sp, #36
.cfi_remember_state .cfi_remember_state
.cfi_def_cfa_offset 20 .cfi_def_cfa_offset 20
@ sp needed @ sp needed
pop {r4, r5, r6, r7, pc} pop {r4, r5, r6, r7, pc}
Fix it, so nobody can copy that.
Change-Id: If5ffeacc7ac3c53a82b260cfb81ef7debc40034a
Signed-off-by: Paul Menzel <[email protected]>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65731
Tested-by: build bot (Jenkins) <[email protected]>
Reviewed-by: Julius Werner <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.