Addressed issue #166

daveshanley · daveshanley · commit dc8011e6fa08 · 2026-03-14T13:31:58.000-04:00
Now we use JSONL
diff --git a/cmd/root_command.go b/cmd/root_command.go
@@ -772,7 +772,7 @@ func Execute(version, commit, date string, fs embed.FS) {
 	rootCmd.Flags().StringP("har", "z", "", "Load a HAR file instead of sniffing traffic")
 	rootCmd.Flags().BoolP("har-validate", "g", false, "Load a HAR file instead of sniffing traffic, and validate against the OpenAPI specification (requires -s)")
 	rootCmd.Flags().StringArrayP("har-allow", "j", nil, "Add a path to the HAR allow list, can use arg multiple times")
-	rootCmd.Flags().StringP("report-filename", "f", "wiretap-report.json", "Filename for any headless report generation output")
+	rootCmd.Flags().StringP("report-filename", "f", "wiretap-report.jsonl", "Filename for any headless report generation output")
 	rootCmd.Flags().BoolP("stream-report", "a", false, "Stream violations to report JSON file as they occur (headless mode)")
 	rootCmd.Flags().BoolP("strict-redirect-location", "r", false, "Rewrite the redirect `Location` header on redirect responses to wiretap's API Gateway Host")
 	rootCmd.Flags().Bool("strict-mode", false, "Enable strict validation to detect undeclared properties, parameters, headers, and cookies")
diff --git a/daemon/stream_output.go b/daemon/stream_output.go
@@ -4,7 +4,6 @@
 package daemon
 
 import (
-	"fmt"
 	jsoniter "github.com/json-iterator/go"
 	"github.com/pb33f/wiretap/shared"
 	"github.com/pterm/pterm"
@@ -27,33 +26,18 @@ func (ws *WiretapService) listenForValidationErrors() {
 
 	go func() {
 		defer f.Close()
-		if _, e := f.WriteString("[]"); e != nil {
-			pterm.Error.Println("cannot write violation to stream: " + err.Error())
-		}
 		for {
 			select {
 			case violations := <-ws.streamChan:
-
 				if ws.stream {
 					lock.Lock()
-
-					fi, _ := f.Stat()
-					_ = os.Truncate(ws.reportFile, fi.Size()-1)
-					if fi.Size() > 2 {
-						_, _ = f.WriteString(",\n")
-					}
 					ws.streamViolations = append(ws.streamViolations, violations...)
-
-					for i, v := range violations {
+					for _, v := range violations {
 						bytes, _ := json.Marshal(v)
-						if _, e := f.WriteString(fmt.Sprintf("%s", bytes)); e != nil {
-							pterm.Error.Println("cannot write violation to stream: " + err.Error())
-						}
-						if i > len(violations)-1 {
-							_, _ = f.WriteString(",\n")
+						if _, e := f.WriteString(string(bytes) + "\n"); e != nil {
+							pterm.Error.Println("cannot write violation to stream: " + e.Error())
 						}
 					}
-					_, _ = f.WriteString("]")
 					lock.Unlock()
 				}
 			}
