Use explicit error conversion where there might be ambiguity#585
Merged
DanGould merged 2 commits intopayjoin:masterfrom Mar 26, 2025
Merged
Use explicit error conversion where there might be ambiguity#585DanGould merged 2 commits intopayjoin:masterfrom
DanGould merged 2 commits intopayjoin:masterfrom
Conversation
Collaborator
Pull Request Test Coverage Report for Build 14087223151Details
💛 - Coveralls |
The Expired variant is explicitly constructed.
From impls are part of the public API. Since this is unused, let's remove it so it doesn't need to be maintained.
DanGould
force-pushed
the
explicit-err-conversions
branch
from
b5fe827 to
4269128
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#570 (comment)
The SystemTime Expired variant is explicitly constructed.
I want to check how the ParseUrl errors are converted too before this goes in.I think the ParseUrl errors can be handled as part of #513 when the variants become public