Closed
Conversation
The gateway is available via POST on /.well-known/ohttp-gateway OHTTP key configuration is available via GET on the same path. In this case the `Accept: application/ohttp-keys` is not required or even checked.
This commit is incomplete since it does not update ohttp-relay (but has been tested locally with an overridden version, including removing the backwards compatible behavior of serving the gateway on / and keys on /ohttp-keys to ensure tests still pass)
Collaborator
Pull Request Test Coverage Report for Build 13168014686Details
💛 - Coveralls |
Contributor
|
This intended to put ohttp-relay cargo update in here and utilizing the e2e test but that will be a new PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR for previewing the changes required for RFC 9540 support, and should be split into two smaller ones:
Although the changes to support this are very simple, because of the lack of use of the ohttp relay in the e2e tests, I had both a false positive and a false negative (i.e. I thought it was implemented correctly when it wasn't, then I thought it was implemented incorrectly when it was), so still not feeling confident about these changes.
As a result of this confusion I have been working on using rcgen to generate a self signed certificate, as in the ohttp-relay tests, so that the
_danger-local-httpsfeature can be removed, and the e2e test doesn't bypass the relay but is truly end to end, but i'm not sure how to expose such functionality without making the ohttp relay significantly more complex both in code and in CLI api, so ideas on how to do this are welcome.The best idea I've got so far is to implement a custom root certificate store that manually adds the webpki roots and optionally a CLI specified root certificate, and gate the additional CLI argument with _test-utils flag, that's still a lot of boilerplate, but feature gating is additive.