Skip to content

consider using http::Uri dependency instead of url::Url #459

@DanGould

Description

@DanGould

Discussed in https://github.com/orgs/payjoin/discussions/288

Originally posted by DanGould June 13, 2024
The payjoin protocol deals with HTTP messages, not ftp/unix/data protocols and so using the lighter weight http::Uri type may be more appropriate than url::Url and give validation control over exactly the types of URLs that we need to deal with.

The original bip78 crate from Kixunil used url so we just kept with it without thinking through this dependency https://github.com/Kixunil/payjoin/blob/master/bip78/Cargo.toml

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Done

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions