This repository was archived by the owner on Dec 19, 2025. It is now read-only.
Reuse HTTP client, and accept typed root cert store#63
Merged
nothingmuch merged 2 commits intopayjoin:mainfrom Mar 14, 2025
Merged
Reuse HTTP client, and accept typed root cert store#63nothingmuch merged 2 commits intopayjoin:mainfrom
nothingmuch merged 2 commits intopayjoin:mainfrom
Conversation
This was referenced Mar 14, 2025
Collaborator
|
I love this new design, and I agree that we don't need to run the ohttp-relay binary in the payjoin e2e tests. If we wanted to we could add a test in |
DanGould
reviewed
Mar 14, 2025
In the rust-payjoin e2e tests the relay is embedded in the test services and as such can just receive a typed RootCertStore argument in a _test-util gated function, instead of loading native certs gated by that same feature.
nothingmuch
force-pushed
the
typed-root-cert-store
branch
from
9598fca to
99cbe1f
Compare
DanGould
approved these changes
Mar 14, 2025
DanGould
added a commit
to payjoin/rust-payjoin
that referenced
this pull request
Mar 14, 2025
Instead of submitting OHTTP requests directly to the directory's OHTTP gateway, give the OHTTP gateway's self signed certificate to the relay so it can connect to it, and exercise the relay in the integration tests. This change updates`payjoin-test-util`'s `Cargo.toml` to use a git origin for the merge commit of payjoin/ohttp-relay#63, as such it needs to be followed up with a commit that specifies an updated version before release.
nothingmuch
added a commit
to payjoin/rust-payjoin
that referenced
this pull request
Mar 17, 2025
Merged
node-smithxby72w
added a commit
to node-smithxby72w/rust-payjoin
that referenced
this pull request
Sep 28, 2025
Instead of submitting OHTTP requests directly to the directory's OHTTP gateway, give the OHTTP gateway's self signed certificate to the relay so it can connect to it, and exercise the relay in the integration tests. This change updates`payjoin-test-util`'s `Cargo.toml` to use a git origin for the merge commit of payjoin/ohttp-relay#63, as such it needs to be followed up with a commit that specifies an updated version before release.
node-smithxby72w
added a commit
to node-smithxby72w/rust-payjoin
that referenced
this pull request
Sep 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of creating an HTTP client once per forward request, a long lived client is cloned for each request.
In the test constructor, requires that a
rustls::RootCertStorebe passed as a configuration for the long lived client directly in fromTestServicesinstead of conditionally checking for an env var specified cert root file.Inexplicably I got it in my head that the e2e tests runs the relay as a binary. Fortunately this is not actually the case, eliminating the potential headache of managing an environment variable with tokio tests. Unfortunately this raises the question, should we run the relay binary in the e2e tests? My vote would be no
Embarrassingly replaces the short lived #61, i mean #62 😳