Conversation
|
Opened as draft because of the breaking nature of this change, and in case #46 is rejected in which case this should be rebased to not depend on it. |
There was a problem hiding this comment.
Do I understand correctly that if #46 is merged as well as this PR, the changes will not break our practical use of this relay implementation in the wild that we're aware of?
Or is your preference not to support both /ohttp-keys AND this change?
#46 should be fine to merge for the stated reason. However, this PR will break unless the payjoin-directory is also updated (2nd commit of payjoin/rust-payjoin#530 which I will shortly make into its own separate PR).
Actually I think we should support both at least for some transition period as it's just 2 lines in the code, and because the ohttp-keys endpoint is depended on not just by the ohttp-relay but also payjoin receivers. I did remove support for it in payjoin/rust-payjoin#530, but only for testing purposes. |
nothingmuch
force-pushed
the
rfc-9540
branch
from
c70c91d to
a736c5f
Compare
nothingmuch
force-pushed
the
rfc-9540
branch
from
a736c5f to
7f07cf8
Compare
DanGould
left a comment
DanGould
left a comment
There was a problem hiding this comment.
utACK 7f07cf8
This requires a change to payjoin-directory to use this gateway uri order to work. Our payjoin-directory change must be backwards compatible, and then once we're convinced ohttp-relays have updated we can roll out a payjoin-directory that removes the backwards compatibility.
nothingmuch
force-pushed
the
rfc-9540
branch
4 times, most recently
from
3f22f93 to
d52c0cb
Compare
A backwards compatible change to support RFC 9540. The directory accepts requests at `/.well-known/ohttp-gateway`. The receiver also fetches OHTTP keys from the new RFC 9540 endpoint, instead of `/ohttp-keys`. Unblocks payjoin/ohttp-relay#47.
RFC 9540 specifies a standard location (/.well-known/ohttp-gateway) for the OHTTP gateway, where the keys can be fetched with a GET request and OHTTP requests to the target resource can be POSTed.
A backwards compatible change to support RFC 9540. The directory accepts requests at `/.well-known/ohttp-gateway`. The receiver also fetches OHTTP keys from the new RFC 9540 endpoint, instead of `/ohttp-keys`. Unblocks payjoin/ohttp-relay#47.
2 participants
Note: This is a breaking change, and requires directory support for RFC 9540 as well.
This change modifies the relay to assume that both the the OHTTP gateway
and the ohttp keys reside at /.well-known/ohttp-gateway, with POST
requests implementing the OHTTP gateway functionality and GET requests
fetching the OHTTP keys.
Extends #46, but does not strictly depend on it.
Depends on #57